GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/456
Revert #452: setExpectedState sets actualState synchronously
@neykov (cc @Graeme-Miller) can you review please?
As discussed in https://github.com/apache/brooklyn-server/pull/454 (due to
the failing test in its PR build for
`LoopOverGroupMembersTestCaseTest.testMultipleChildrenWhichPass`), a lot of
places expect the actual state to have been calculated/set by the time that
`setExpectedState()` has returned.
Short-term, it's better than we live with the race-condition fixed by
https://github.com/apache/brooklyn-server/pull/452, rather than change the
semantics of `setExpectedState()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
rollback-pr-452-partly
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #456
----
commit e7c3b2b07a09b0770cce1784e4b046a30e36b53b
Author: Aled Sage <[email protected]>
Date: 2016-11-23T14:04:35Z
Revert #452: setExpectedState sets actualState synchronously
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
