[
https://issues.apache.org/jira/browse/BROOKLYN-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15691356#comment-15691356
]
ASF GitHub Bot commented on BROOKLYN-401:
-----------------------------------------
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-server/pull/459
[BROOKLYN-401] Fix failing GC tasks test
Background tasks get in the way, messing with the logic of what to evict
next.
Note that this only changes the expectations in the tests, doesn't improve
the GC as suggested in BROOKLYN-401.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/brooklyn-server
fix/failing-gc-task-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/459.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #459
----
commit d488584ff44093aa5fddba82940268b4c8f40ef2
Author: Svetoslav Neykov <[email protected]>
Date: 2016-11-23T21:00:10Z
Fix failing GC tasks test
Background tasks get in the way, messing with the logic of what to evict
next.
----
> Task GC should ignore transient tasks per entity/tag limits
> -----------------------------------------------------------
>
> Key: BROOKLYN-401
> URL: https://issues.apache.org/jira/browse/BROOKLYN-401
> Project: Brooklyn
> Issue Type: Improvement
> Reporter: Svetoslav Neykov
>
> The task GC will include tasks-to-be-deleted when checking whether the per
> entity/tag limits are reached. This could lead to the eviction of tasks which
> would otherwise be kept if those the tasks-to-be-deleted were deleted
> beforehand.
> It tries to evict any such tasks, but new instances could be added in the
> time between clean up and limit checking.
> Improve: exclude transient and expired tasks from the list of tasks to evict.
> They will be cleaned up anyway.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
