Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/468#discussion_r89639989
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocationConfig.java
---
@@ -293,6 +293,12 @@
public static final ConfigKey<Map<String,Object>> TEMPLATE_OPTIONS =
ConfigKeys.newConfigKey(
new TypeToken<Map<String, Object>>() {}, "templateOptions",
"Additional jclouds template options");
+ @Beta
+ public static final ConfigKey<Boolean>
USE_PUBLIC_ENDPOINT_AS_PRIVATE_ENDPOINT = ConfigKeys.newBooleanConfigKey(
+ "usePublicEndpointAsPrivateEndpoint",
--- End diff --
I wonder if there is a better name for this - it's not clear that it refers
to VMs provisioned using the JcloudsLocation, and thus risks being confused
with the cloud endpoint. Perhaps would be better as:
```
@Beta
public static final ConfigKey<Boolean>
USE_MACHINE_PUBLIC_ADDRESS_AS_PRIVATE_ADDRESS = ConfigKeys.newBooleanConfigKey(
"useMachinePublicAddressAsPrivateAddress",
"When true we will use the public IP/Hostname of a provisioned
VM as the private IP/Hostname",
false);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
