Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/473
  
    Thanks @grkvlt - I've changed the declaration of `Task<?> task` as 
suggested.
    I haven't changed to use `try (...)` for closing the `LogWatcher` (we 
certainly could use that java 7 idiom, but don't do it in many other places 
either.
    I haven't changed the `log.isDebugEnabled()` - other than noise in the 
code, there's a slight benefit of avoiding the string concatenation/creation. 
Given that the `isDebugEnabled` guard was already there (rather than me adding 
it), I'm fine leaving it.
    
    Merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to