Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/491#discussion_r92645673
  
    --- Diff: core/src/main/java/org/apache/brooklyn/feed/ssh/SshFeed.java ---
    @@ -270,6 +270,7 @@ private SshPollValue exec(String command, 
Map<String,String> env) throws IOExcep
             ConfigBag flags = ConfigBag.newInstanceExtending(config().getBag())
                 .configure(SshTool.PROP_NO_EXTRA_OUTPUT, true)
                 .configure(SshTool.PROP_OUT_STREAM, stdout)
    +            .configure(SshMachineLocation.CLOSE_CONNECTION, true)
    --- End diff --
    
    This is really expensive. It means that we close all connections in our 
ssh-pool-cache in `SshMachineLocation`.
    (As an aside, I wonder if that works properly! I hope that invalidating the 
cache won't terminate other ssh commands that are executing in other threads!).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to