Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/490#discussion_r92832429
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java ---
@@ -988,7 +988,7 @@ protected void setCatalogItemId(BrooklynObject item,
String catalogItemId) {
} catch (Exception e) {
Exceptions.propagateIfFatal(e);
}
- return new
ClassLoaderUtils(reflections.getClassLoader()).loadClass(jType);
+ return new ClassLoaderUtils(reflections.getClassLoader(),
managementContext).loadClass(jType);
--- End diff --
I fail to see how this fixes the test (looking at the `ClassLoaderUtils`
code). If `jType` has a prefix it should be able to load it anyway. If not then
it will fail.
Looks good otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
