Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/488#discussion_r92844737
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -486,8 +486,8 @@ public DslConfigSupplier(DslComponent component, String
keyName) {
if (targetEntityMaybe.isAbsent()) return Maybe.absent("Target
entity not available");
EntityInternal targetEntity = (EntityInternal)
targetEntityMaybe.get();
- ConfigKey<?> key =
targetEntity.getEntityType().getConfigKey(keyName);
- Maybe<? extends Object> result =
targetEntity.config().getNonBlocking(key != null ? key :
ConfigKeys.newConfigKey(Object.class, keyName));
+ ConfigKey<Object> key = (ConfigKey<Object>)
targetEntity.getEntityType().getConfigKey(keyName);
+ Maybe<Object> result =
targetEntity.config().getNonBlocking(key != null ? key :
ConfigKeys.newConfigKey(Object.class, keyName));
--- End diff --
Could instead help the compiler by assigning `key != null ? key :
ConfigKeys.newConfigKey(Object.class, keyName)` to an intermediate
`ConfigKey<?>` value. Same below.
Given we are casting below anyway could remove generics altogether and stop
pretending we are "safe".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
