Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/462#discussion_r94785113
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterUnwrappingTest.java
---
@@ -146,8 +151,9 @@ public void testRootParametersUnwrapped() {
CatalogItem<?, ?> item = catalog.getCatalogItem(SYMBOLIC_NAME,
TEST_VERSION);
AbstractBrooklynObjectSpec<?,?> spec = catalog.peekSpec(item);
List<SpecParameter<?>> params = spec.getParameters();
- assertEquals(params.size(), NUM_APP_DEFAULT_CONFIG_KEYS + 1,
"params="+params);
assertTrue(Iterables.tryFind(params,
nameEqualTo("simple")).isPresent());
+ assertTrue(Iterables.tryFind(params,
nameEqualTo(SHARED_CONFIG.getName())).isPresent());
+ assertEquals(params.size(), NUM_APP_DEFAULT_CONFIG_KEYS + 2,
"params="+params);
--- End diff --
Unrelated, but in the case of unwrapping the spec because we are expecting
a non-app spec it's surprising to inherit the wrapper app config (and anything
else from it).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
