Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/519#discussion_r96595304
  
    --- Diff: 
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/util/DefaultExceptionMapper.java
 ---
    @@ -72,7 +72,7 @@ public Response toResponse(Throwable throwable1) {
                     Exceptions.collapse(throwable1));
             } else {
                 LOG.debug("REST request running as {} threw: {}", 
Entitlements.getEntitlementContext(), 
    --- End diff --
    
    This will lose the stack trace information; I suggest replacing this one 
line with one at info and one at debug, something like
    ```java
    LOG.info("CorsImplSupplierFilter running in {} caught: {}", 
Entitlements.getEntitlementContext(), throwable1.getMessage());
    LOG.debug("CorsImplSupplierFilter exception details", throwable1);
    ```
    similarly in other places where the same thing is being done 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to