Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/530#discussion_r97329773
  
    --- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
 ---
    @@ -1065,6 +1066,13 @@ protected MachineLocation obtainOnce(ConfigBag 
setup) throws NoMachinesAvailable
                     LOG.warn("Problem generating log message summarising 
completion of jclouds machine provisioning "+machineLocation+" by "+this, e);
                 }
     
    +            if (customizers.size() > 0) {
    +                machineLocation.config().set(JCLOUDS_LOCATION_CUSTOMIZERS, 
customizers);
    +            }
    +            if (machineCustomizers.size() > 0) {
    +                machineLocation.config().set(MACHINE_LOCATION_CUSTOMIZERS, 
machineCustomizers);
    +            }
    --- End diff --
    
    Can you instead add the config for `JCLOUDS_LOCATION_CUSTOMIZERS` at 
[construction 
time](https://github.com/apache/brooklyn-server/blob/master/locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java#L2056-L2099)
 so migrated settings are all at one place.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to