[
https://issues.apache.org/jira/browse/BROOKLYN-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834678#comment-15834678
]
ASF GitHub Bot commented on BROOKLYN-427:
-----------------------------------------
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/530#discussion_r97330165
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2219,7 +2227,7 @@ public void release(MachineLocation rawMachine) {
Exception tothrow = null;
- ConfigBag setup = config().getBag();
+ ConfigBag setup = ((LocationInternal)machine).config().getBag();
--- End diff --
IIRC it is needed to be able to do the `getBag()`
> JcloudsLocation is not releasing its customizers
> ------------------------------------------------
>
> Key: BROOKLYN-427
> URL: https://issues.apache.org/jira/browse/BROOKLYN-427
> Project: Brooklyn
> Issue Type: Bug
> Reporter: Geoff Macartney
> Priority: Minor
>
> preRelease and postRelease of JcloudsLocationCustomizers are not being
> called as expected during the release of a Jclouds machine location.
> The problem is that the "setup" used in JcloudsLocation.obtainOnce includes a
> copy of the flags passed from
> MachineLifecycleEffectorTasks#stopAnyProvisionedMachines,
> which includes the customizers. However, the "setup" used in the "release"
> method of JcloudsLocation is taken from the JcloudsLocation itself, which
> is the provisioning (i.e. parent) location, which doesn't have those
> customizers in it.
> It would actually make more sense to get the location customizers from
> the machine location, as a given parent could have mutiple machines
> with different customizers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
