Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/529
* naming
* I think a more appropriate name for the interface would be
`ConnectivityResolver` and for the implementation `DefaultConnectivityResolver`
(could even drop the location part).
* whether the class should extend BasicJcloudsLocationCustomizer:
* No
* whether we should include the publishNetworks option right now:
* it's a nice to have feature, though not sure the current format is
optimal, see comments above. If in doubt could include it disabled by default.
* whether ManagementAddressResolveOptions is the right way to convey
information between the location and the customiser:
* My first thought was that `JcloudsLocation` + `config` should be
enough, potentially including `credentialsOverride`. Why include both `config`
and `options` if it can be reconstructed on the other side. I favour minimal
interfaces which don't duplicate data. But on the other hand I'm happy to leave
as is, especially if the bean is reused at other places. Could clean it up in
future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
