GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/541
Fix ReachableSocketFinderTest (so not time-sensitive)
Tests sometimes failed on apache Jenkins, because 100ms wasnât long
enough for the other thread(s) to complete.
e.g. see
https://builds.apache.org/job/brooklyn-master-build/org.apache.brooklyn$brooklyn-utils-common/758/testReport/junit/org.apache.brooklyn.util.net/ReachableSocketFinderTest/testGetReachableSockets/
```
2017-01-26 16:54:15,390 INFO TESTNG INVOKING CONFIGURATION: "Surefire
test" - @BeforeMethod
org.apache.brooklyn.util.net.ReachableSocketFinderTest.setUp()
2017-01-26 16:54:15,390 INFO TESTNG PASSED CONFIGURATION: "Surefire test"
- @BeforeMethod org.apache.brooklyn.util.net.ReachableSocketFinderTest.setUp()
finished in 0 ms
2017-01-26 16:54:15,390 INFO TESTNG INVOKING: "Surefire test" -
org.apache.brooklyn.util.net.ReachableSocketFinderTest.testGetReachableSockets()
2017-01-26 16:54:15,439 INFO TESTNG FAILED: "Surefire test" -
org.apache.brooklyn.util.net.ReachableSocketFinderTest.testGetReachableSockets()
finished in 48 ms
java.lang.AssertionError: expected=[1.1.1.1:1111, 1.1.1.3:1113],
actual=[1.1.1.1:1111]: Expected iterator returned more elements than the actual
iterator.
at
org.apache.brooklyn.util.net.ReachableSocketFinderTest.testGetReachableSockets(ReachableSocketFinderTest.java:130)
```
I could reproduce locally a failure like this by changing the timeout of
that test from 100ms to 1ms.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
fix-ReachableSocketFinderTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/541.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #541
----
commit 91b3b8dd320157e2b9cc815dd6d920ea2371e625
Author: Aled Sage <[email protected]>
Date: 2017-01-27T14:36:41Z
Fix ReachableSocketFinderTest (so not time-sensitive)
Tests sometimes failed on apache Jenkins, because 100ms wasnât long
enough for the other thread(s) to complete.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
