Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/540
LGTM; merging now.
Jenkins build failure is unrelated (so we should fix that separately) -
failure is `ServiceFailureDetectorYamlRebindTest.testRebindWhenHealthy`:
```
2017-01-27 12:51:55,375 INFO TESTNG INVOKING: "Surefire test" -
org.apache.brooklyn.camp.brooklyn.ServiceFailureDetectorYamlRebindTest.testRebindWhenHealthy()
2017-01-27 12:51:55,489 INFO CAMP created
'BasicApplicationImpl{id=rqr04h12aw}'
2017-01-27 12:51:55,490 INFO Test - created
org.apache.brooklyn.camp.spi.Assembly@618b82af[id=rqr04h12aw; type=Assembly]
2017-01-27 12:51:55,490 INFO App - BasicApplicationImpl{id=rqr04h12aw}
2017-01-27 12:51:55,534 INFO Started application
BasicApplicationImpl{id=rqr04h12aw}
2017-01-27 12:51:55,535 INFO Waiting on 12 task(s)
2017-01-27 12:51:55,537 INFO App started:
BasicApplicationImpl{id=rqr04h12aw} rqr04h12aw
displayName = Application (rqr04h12aw)
locations = []
brooklyn.wrapper_app = true
camp.template.id = mwX3Y5Hf
application.id: rqr04h12aw
entity.id: rqr04h12aw
service.isUp: true
service.state: running
service.state.expected: running @ 1485521515534 / Fri Jan 27 12:51:55
UTC 2017
Enrichers:
Transformer{uniqueTag=service.isUp if no service.notUp.indicators,
running=true, entity=BasicApplicationImpl{id=rqr04h12aw}, id=awim2ny9pg}
enricher.sourceSensor[ConfigKey:org.apache.brooklyn.api.sensor.Sensor] =
Sensor: service.notUp.indicators (java.util.Map)
enricher.suppressDuplicates[ConfigKey:java.lang.Boolean] = true
enricher.targetSensor[ConfigKey:org.apache.brooklyn.api.sensor.Sensor] =
Sensor: service.isUp (java.lang.Boolean)
enricher.transformation[ConfigKey:com.google.common.base.Function] =
if[{Predicates.not(Predicates.isNull())=forPredicate(Predicates.equalTo(0)(sizeFunction(keys)))}]-else[UNCHANGED]
ComputeServiceState{uniqueTag=service.state.actual, running=true,
entity=BasicApplicationImpl{id=rqr04h12aw}, id=ku855sln4d}
ComputeServiceIndicatorsFromChildrenAndMembers{uniqueTag=service-lifecycle-indicators-from-children-and-members,
running=true, entity=BasicApplicationImpl{id=rqr04h12aw}, id=wtzpmg4jop}
enricher.aggregating.fromChildren[ConfigKey:java.lang.Boolean] =
true
enricher.aggregating.fromMembers[ConfigKey:java.lang.Boolean] =
true
enricher.service_state.children_and_members.quorum.running[ConfigKey:org.apache.brooklyn.util.collections.QuorumCheck]
= QuorumCheck[all;require=0,100.0%]
enricher.service_state.children_and_members.quorum.up[ConfigKey:org.apache.brooklyn.util.collections.QuorumCheck]
= QuorumCheck[all;require=0,100.0%]
TestEntityImpl{id=v5ihf744cj} v5ihf744cj
displayName = targetEntity
locations = []
camp.template.id = Q78Bl0WL
application.id: rqr04h12aw
catalog.id: my-app:1.2.3
entity.id: v5ihf744cj
service.isUp: true
service.state: running
service.state.expected: running @ 1485521515517 / Fri Jan 27 12:51:55
UTC 2017
test.attributeAndConfString: defaultval
Enrichers:
Transformer{uniqueTag=service.isUp if no service.notUp.indicators,
running=true, entity=TestEntityImpl{id=v5ihf744cj}, id=bit9is9fwz}
enricher.sourceSensor[ConfigKey:org.apache.brooklyn.api.sensor.Sensor] =
Sensor: service.notUp.indicators (java.util.Map)
enricher.suppressDuplicates[ConfigKey:java.lang.Boolean] = true
enricher.targetSensor[ConfigKey:org.apache.brooklyn.api.sensor.Sensor] =
Sensor: service.isUp (java.lang.Boolean)
enricher.transformation[ConfigKey:com.google.common.base.Function] =
if[{Predicates.not(Predicates.isNull())=forPredicate(Predicates.equalTo(0)(sizeFunction(keys)))}]-else[UNCHANGED]
ServiceFailureDetector{uniqueTag=service.state.actual,
running=true, entity=TestEntityImpl{id=v5ihf744cj}, id=ao90dlvpbt}
2017-01-27 12:51:55,558 INFO Rebinding app, using mementoDir
/tmp/ServiceFailureDetectorYamlRebindTest-ZB4v; object store null
2017-01-27 12:51:55,645 INFO Rebinding from
/tmp/ServiceFailureDetectorYamlRebindTest-ZB4v for master G9l2JKcw...
2017-01-27 12:51:55,749 INFO Rebind complete (MASTER) in 189ms: 1 app, 2
entities, 0 locations, 0 policies, 5 enrichers, 0 feeds, 1 catalog item
2017-01-27 12:51:55,753 WARN Setting TestEntityImpl{id=v5ihf744cj} on-fire
due to problems when expected running, up=false, not-up-indicators:
{test-indicator-1=Simulate a problem}
2017-01-27 12:51:55,753 WARN Setting BasicApplicationImpl{id=rqr04h12aw}
on-fire due to problems when expected running, up=false, not-up-indicators:
{service-lifecycle-indicators-from-children-and-members=TestEntityImpl{id=v5ihf744cj}
is not up}
2017-01-27 12:52:25,752 INFO succeedsEventually exceeded max attempts or
timeout - 69 attempts lasting 30000 ms, for
RunnableAdapter(org.apache.brooklyn.core.entity.RecordingSensorEventListener$1@5858ca9d)
2017-01-27 12:52:25,752 INFO failed succeeds-eventually, 69 attempts,
30001ms elapsed (rethrowing): java.lang.AssertionError: No event matching
filter sensorSatisfies(Predicates.equalTo(Sensor: ha.entityFailed
(org.apache.brooklyn.policy.ha.HASensors$FailureDescriptor)))
2017-01-27 12:52:25,756 INFO TESTNG FAILED: "Surefire test" -
org.apache.brooklyn.camp.brooklyn.ServiceFailureDetectorYamlRebindTest.testRebindWhenHealthy()
finished in 30378 ms
java.lang.AssertionError: failed succeeds-eventually, 69 attempts, 30001ms
elapsed: AssertionError: No event matching filter
sensorSatisfies(Predicates.equalTo(Sensor: ha.entityFailed
(org.apache.brooklyn.policy.ha.HASensors$FailureDescriptor)))
at
org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:1008)
at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:895)
at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:888)
at
org.apache.brooklyn.core.entity.RecordingSensorEventListener.assertHasEventEventually(RecordingSensorEventListener.java:114)
at
org.apache.brooklyn.camp.brooklyn.ServiceFailureDetectorYamlRebindTest.runRebindWhenHealthy(ServiceFailureDetectorYamlRebindTest.java:109)
at
org.apache.brooklyn.camp.brooklyn.ServiceFailureDetectorYamlRebindTest.testRebindWhenHealthy(ServiceFailureDetectorYamlRebindTest.java:54)
Caused by: java.lang.AssertionError: No event matching filter
sensorSatisfies(Predicates.equalTo(Sensor: ha.entityFailed
(org.apache.brooklyn.policy.ha.HASensors$FailureDescriptor)))
at
org.apache.brooklyn.core.entity.RecordingSensorEventListener.assertHasEvent(RecordingSensorEventListener.java:110)
at
org.apache.brooklyn.core.entity.RecordingSensorEventListener$1.run(RecordingSensorEventListener.java:117)
at
org.apache.brooklyn.test.Asserts$RunnableAdapter.call(Asserts.java:1359)
at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:973)
... 33 more
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
