Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/544#discussion_r99380876
  
    --- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BrooklynImageChooser.java
 ---
    @@ -73,7 +73,7 @@ protected static boolean 
imageNameContainsWordCaseInsensitive(Image img, String
             return 
img.getName().toLowerCase().matches("(.*[^a-z])?"+pattern.toLowerCase()+"([^a-z].*)?");
         }
         
    -    public double punishmentForOldOsVersions(Image img, OsFamily family, 
double minVersion) {
    +    private double punishmentForOldOsVersions(Image img, OsFamily family, 
double minVersion) {
    --- End diff --
    
    Can you make this `protected`. If someone needs to fine-tune the selection 
the easiest thing to do would be to extend this class and configure an override 
in the location.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to