GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/551

    BROOKLYN-421: Adds DSL for $brooklyn:urlEncode(...)

    As stated in the comments within the code, the url encoding is based on 
"x-www-form-urlencoded". Therefore care must be taken if encoding username or 
password (e.g. in http://myuser:mypass@myhost";). It will not encode space 
correctly, and will not escape "*". The latter we can probably live with, but 
the former will be wrong.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-421

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #551
    
----
commit fa387821a0594fbd107f0edcb1ee73144a30987b
Author: Aled Sage <[email protected]>
Date:   2017-02-06T12:55:03Z

    Urls.encode(String) specifies UTF-8

commit 316452e578d7199227cf9a5472a4cde7bf2faf8a
Author: Aled Sage <[email protected]>
Date:   2017-01-20T22:29:07Z

    BROOKLYN-421: Adds DSL for $brooklyn:urlEncode(...)

commit 9275edb58c09081fe6ec9d9d5a7bbb241e3f5e8f
Author: Aled Sage <[email protected]>
Date:   2017-02-06T13:53:25Z

    AbstractYamlRebindTest: updates as per AbstractYamlTest
    
    Replaced the createAndStartApplication impl with that from
    AbstractYamlTest. (Before this change, I saw a NoSuchElementException
    because it failed to find the task for the start effector - I’m guessing
    there’s a race for when that task is created).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to