Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/462#discussion_r100798508
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/guava/Maybe.java ---
@@ -457,6 +457,8 @@ public boolean equals(Object obj) {
Maybe<?> other = (Maybe<?>)obj;
if (!isPresent())
return !other.isPresent();
+ if (!other.isPresent())
+ return false;
--- End diff --
that seems harsh to me; could cause problems if we serialized a `Maybe`?
could compare the exceptions but for now I will just add javadoc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
