Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/480#discussion_r101877907
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -539,8 +550,9 @@ protected String resolveKeyName(boolean immediately) {
@Override
public final Maybe<Object> getImmediately() {
Maybe<Entity> targetEntityMaybe = component.getImmediately();
- if (targetEntityMaybe.isAbsent()) return Maybe.absent("Target
entity not available");
+ if (targetEntityMaybe.isAbsent()) return
Maybe.<Object>cast(targetEntityMaybe);
EntityInternal targetEntity = (EntityInternal)
targetEntityMaybe.get();
+ checkAndTagForRecursiveReference(targetEntity);
--- End diff --
the tag is left on the task. you're right that could cause problems if the
calling code isn't in a task (maybe it always will be but safer not to assume).
TODO remove tag afterwards
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
