[ 
https://issues.apache.org/jira/browse/BROOKLYN-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877625#comment-15877625
 ] 

Valentin Aitken commented on BROOKLYN-442:
------------------------------------------

It will also help improving tests covarage simultaneously for winrm and ssh by 
reusing things like SshToolAbstractIntegrationTest for winrm.

> Introduce common interface for SshTool and WinRmTool
> ----------------------------------------------------
>
>                 Key: BROOKLYN-442
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-442
>             Project: Brooklyn
>          Issue Type: Improvement
>            Reporter: Valentin Aitken
>
> This will help reusing code in:
> # AbstractSoftwareProcessWinRmDriver and AbstractSoftwareProcessSshDriver. 
> More precisely it will help abstracting some actions for {{ScriptHelper}} and 
> {{WinRmExecuteHelper}}.
> # It will also help reusing ExecWithLoggingHelpers for WinRmMachineLocation.
> # The most obvious benefit at the moment is for Implementing SshFeed like for 
> WinRm like I did in https://github.com/apache/brooklyn-server/pull/564



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to