Graeme Miller created BROOKLYN-447:
--------------------------------------
Summary: waitForSshable deprecated without replacement
Key: BROOKLYN-447
URL: https://issues.apache.org/jira/browse/BROOKLYN-447
Project: Brooklyn
Issue Type: Bug
Reporter: Graeme Miller
Priority: Minor
In [this PR|https://github.com/apache/brooklyn-server/pull/529] the config
waitForSshable was deprecated in favour of the newly added config
pollForFirstReachableAddress. However, setting pollForFirstReachableAddress
does not have the same result as setting waitForSshable.
Issue 1)
waitForSshable is a config key that, when set to true, instructs the
JCloudsLocation ensure that AMP can ssh to the location after it has been
setup. pollForFirstReachableAddress will wait for the location to be setup and
then will attempt to ensure at least one address is reachable. It would be
possible to pass the pollForFirstReachableAddress check without being sshable.
Issue 2)
waitForSshable is also used to control creating users. If waitForSshable is set
to true then createUser is
[called|https://github.com/apache/brooklyn-server/blob/master/locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java#L804].
Create user will ssh into the JCloudsLocation and setup a user, which will of
course fail if we cannot SSH into the location. For this reason in situations
where we expect we will not be able to SSH in (e.g. using a docker container
location based on an image without sshd), then waitForSshable is usually set to
false which ensures we don't wait for it to be SSHable and that we don't
attempt to create a user. pollForFirstReachableAddress does not control the
creation of users.
------------------------------------------
I suggest that we remove the deprecated status from waitForSshable. Also, I
think it would be advisable to create a new piece of config called createUser
that controls whether or not we create users. This way we can de-couple user
creation from waitForSshable
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
