Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/485#discussion_r107147365
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
 ---
    @@ -417,6 +419,53 @@ else for (String key: otherKeys) {
             return result;
         }
     
    +    public static Map<?,?> getCatalogMetadata(String yaml) {
    +        Map<?,?> itemDef = Yamls.getAs(Yamls.parseAll(yaml), Map.class);
    +        return getFirstAsMap(itemDef, "brooklyn.catalog").orNull();        
    +    }
    +    
    +    public static VersionedName getVersionedName(Map<?,?> catalogMetadata) 
{
    +        String id = getFirstAs(catalogMetadata, String.class, 
"id").orNull();
    +        String version = getFirstAs(catalogMetadata, String.class, 
"version").orNull();
    +        String symbolicName = getFirstAs(catalogMetadata, String.class, 
"symbolicName").orNull();
    +        symbolicName = findAssertingConsistentIfSet("symbolicName", 
symbolicName, getFirstAs(catalogMetadata, String.class, 
"symbolic-name").orNull());
    --- End diff --
    
    @aledsage My understanding is that the `symbolic-name` comes from the 
`MANIFEST.MF` file. If not, I agree we should support only one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to