GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/608
`BundleMaker` REST call allowing to add ZIP/JAR to catalog - Part #2
Builds on top of #485. It implements the missing bits and pieces, such as:
- fields `version` and `bundle` are required under `brooklyn.catalog` when
uploading a ZIP/JAR archive
- returns 400 HTTP status code is anything goes wrong during the process of
the archive (as this is a bad input, therefore a bad request)
- avoid using the `CatalogPopulator` as it reloads all bundles. Instead, it
uses the new `CatalogBundleLoader` that loads only a given bundle
- if the bundle has been installed, but the CAMP parser fails, the bundle
is uninstalled
- adds more unit tests, especially to check error handling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-server feature/upload-archive
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/608.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #608
----
commit 178f81591e5a9786157d768efe2091d16763ed9a
Author: Alex Heneveld <[email protected]>
Date: 2016-12-12T16:55:49Z
add ZIP or JAR via REST API, with tests
commit 2a8b4c75c836ace488bc23920ac69a1e0c66cede
Author: Alex Heneveld <[email protected]>
Date: 2017-03-09T09:59:56Z
require bundle name/version defined in catalog.bom when POSTing a ZIP/JAR
accepts id, symbolicName, or symbolic-name under brooklyn.catalog;
if osgi bundle manifest supplied, it must match.
commit 203d0d75e3edfaf44c5f15808cd4e4df0c322244
Author: Thomas Bouron <[email protected]>
Date: 2017-03-23T16:04:43Z
Require bundle and version fields when uploading an archive through the
REST API
commit 37ad7e13849da29b34c7712c3aa589aa3b1dbf5a
Author: Thomas Bouron <[email protected]>
Date: 2017-03-23T16:05:29Z
Separate the CatalogPopulator from the CatalogBundleLoader
commit 088f9e340e9415ed443f973c213014cd7bcae982
Author: Thomas Bouron <[email protected]>
Date: 2017-03-23T16:15:24Z
Using the new CatalogBundleLoader and make sure the REST API returns a 400
+ uninstall the bundle if an error occur
commit 61d6f338c0e363e63ec50221dbbe2e45e737b7b0
Author: Thomas Bouron <[email protected]>
Date: 2017-03-23T16:52:38Z
Add unit tests for the new upload archive feature
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
