Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/610#discussion_r107880463
--- Diff:
core/src/test/java/org/apache/brooklyn/core/effector/http/HttpCommandEffectorHttpBinTest.java
---
@@ -38,42 +54,93 @@
import com.google.common.collect.ImmutableMap;
import com.jayway.jsonpath.JsonPath;
-public class HttpCommandEffectorIntegrationTest {
+public class HttpCommandEffectorHttpBinTest {
final static Effector<String> EFFECTOR_HTTPBIN =
Effectors.effector(String.class, "Httpbin").buildAbstract();
+ private TestHttpServer server;
+ private String serverUrl;
private TestApplication app;
private EntityLocal entity;
+ public static final class HttpBinRequestHandler implements
HttpRequestHandler {
--- End diff --
Would it be simpler to use BetterMockWebServer here as in
https://github.com/duncangrant/brooklyn-server/blob/1c064b284757ed0c794cbf8f3a6d65e34564af3a/core/src/test/java/org/apache/brooklyn/core/effector/http/HttpCommandEffectorTest.java#L68-L70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
