Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/611#discussion_r108627254
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/effector/MethodEffector.java ---
    @@ -133,6 +133,10 @@ public MethodEffector(Method method) {
             this(new AnnotationsOnMethod(method.getDeclaringClass(), method), 
null);
         }
     
    +    /**
    +     * @deprecated since 0.11.0; explicit groovy utilities/support will be 
deleted.
    +     */
    +    @Deprecated
    --- End diff --
    
    My rule-of-thumb... if one might get at the code via a yaml blueprint (so 
never seeing a deprecation warning in your IDE/compiler), then we should 
include a log.warn. But if we can assume that the user will get compiler 
warnings, then that is sufficient.
    
    I believe that this will only get called directly in code, so one should 
see a compiler warning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to