[jira] [Created] (BROOKLYN-461) Condition that always return true

[JC (JIRA)]

JC created BROOKLYN-461:
---------------------------

             Summary: Condition that always return true
                 Key: BROOKLYN-461
                 URL: https://issues.apache.org/jira/browse/BROOKLYN-461
             Project: Brooklyn
          Issue Type: Bug
            Reporter: JC
            Priority: Trivial


Hi

In recent github mirror of broolyn-server, I've found the following issue in 
equals implementation.

Path: 
utils/common/src/main/java/org/apache/brooklyn/util/collections/CollectionMerger.java

{code}
196 
197             @Override
198             public boolean equals(Object o) {
199                 if (!(o instanceof Ref)) {
200                     return false;
201                 }
202                 return ((Ref)o).obj == ((Ref)o).obj;
203             }
{code}

Line 202 should be like this?
{code}
202                 return this.obj == ((Ref)o).obj;
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)