Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/645#discussion_r113641998
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java ---
    @@ -314,11 +318,30 @@ protected void preprocessManifestFiles() throws 
Exception {
         }
     
         @SuppressWarnings("deprecation")
    -    protected void rebuildCatalog() {
    +    protected void installBundlesAndRebuildCatalog() {
             
             // Build catalog early so we can load other things
             checkEnteringPhase(2);
             
    +        // Install bundles
    +        if (rebindManager.persistBundlesEnabled) {
    +            logRebindingDebug("RebindManager installing bundles: {}", 
mementoManifest.getBundleIds());
    +            for (ManagedBundleMemento bundleM : 
mementoManifest.getBundles().values()) {
    +                logRebindingDebug("RebindManager installing bundle {}", 
bundleM.getId());
    +                try {
    +                    InputStream in = bundleM.getJarContent().openStream();
    --- End diff --
    
    suggest do this as try-with-resources


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to