Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/575#discussion_r114517277
--- Diff:
core/src/main/java/org/apache/brooklyn/core/location/BasicLocationRegistry.java
---
@@ -372,7 +377,10 @@ public final Location getLocationManaged(String spec,
Map locationFlags) {
if (resolver != null) {
try {
- return (Maybe)
Maybe.of(resolver.newLocationSpecFromString(spec, locationFlags, this));
+ LocationSpec<? extends Location> specO =
resolver.newLocationSpecFromString(spec, locationFlags, this);
--- End diff --
I feel like the naming in this function has gotten a bit lost. We have a
spec and a specO and it took me a bit too much time to understand what I was
seeing. Can't think of a better naming convention now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
