Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/681
  
    LGTM (though I'v just read the code rather than testing it).
    
    Note that in `SshMachineLocation`, it caches the sessions and reuses them 
only if a given set of config keys are identical (e.g. usename, password, etc).
    
    I'm not suggesting you change this code to do that, but it's something 
worth bearing in mind.
    
    @neykov any more comments/concerns before we merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to