[
https://issues.apache.org/jira/browse/BROOKLYN-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024943#comment-16024943
]
ASF GitHub Bot commented on BROOKLYN-490:
-----------------------------------------
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/703
BROOKLYN-490: propagate failure in LoopOverGroupMembersTestCase
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-490
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/703.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #703
----
commit 035634592d90ca3f6673c285711ef572753cabe2
Author: Aled Sage <[email protected]>
Date: 2017-05-25T15:48:05Z
Tidy LoopOverGroupMembersTestCase test
commit 730241e015ce339637942626b84136268342503a
Author: Aled Sage <[email protected]>
Date: 2017-05-25T16:13:19Z
BROOKLYN-490: propagate failure in LoopOverGroupMembersTestCase
----
> Failure of LoopOverGroupMembersTestCase doesn't propagate.
> ----------------------------------------------------------
>
> Key: BROOKLYN-490
> URL: https://issues.apache.org/jira/browse/BROOKLYN-490
> Project: Brooklyn
> Issue Type: Bug
> Reporter: Svetoslav Neykov
> Attachments: Screen Shot 2017-05-09 at 10.55.01.png
>
>
> When child test-cases of LoopOverGroupMembersTestCase fail the
> LoopOverGroupMembersTestCase node's start method still succeeds. It's marked
> on fire, but the start command is "complete" and therefore the parent
> test-case is not set on fire.
> Leads to false negatives in tests - the test case fails, but the app is still
> green.
> In the screenshot "from external node" is a TestCase, "host.address:8000" is
> a LoopOverGroupMembersTestCase. So even though the latter is ON_FIRE it's not
> propagated to the parent TestCase.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
