Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/715#discussion_r120347806
--- Diff:
core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java
---
@@ -211,7 +226,7 @@ private HttpRequest buildHttpRequest(String httpVerb,
URI uri, Map<String, Strin
if (!body.equals("")) body += "&";
body += URLEncoder.encode(entry.getKey(),
StandardCharsets.UTF_8.toString()) + "=" + URLEncoder.encode(entry.getValue(),
StandardCharsets.UTF_8.toString());
} catch (UnsupportedEncodingException e) {
- e.printStackTrace();
+ throw Throwables.propagate(e);
--- End diff --
why not `Exceptions.propagate(e);`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
