Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-client/pull/54#discussion_r121912681
  
    --- Diff: cli/api/entity_config/config.go ---
    @@ -52,7 +52,7 @@ func ConfigValueAsBytes(network *net.Network, 
application, entity, config string
     
     func SetConfig(network *net.Network, application, entity, config, value 
string) (string, error) {
        url := fmt.Sprintf("/v1/applications/%s/entities/%s/config/%s", 
application, entity, config)
    -   val := []byte(value)
    +   val := []byte("\""+value+"\"")
    --- End diff --
    
    This will prevent setting json containers/numbers. Currently you can set 
both `'{key: 1}'` and `'"mystring"'`.
    
    * Should we add an option which indicates the value is json?
    * Do we care about backwards compatibility where someone could already be 
setting strings with the quotes added?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to