Github user Graeme-Miller commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/747#discussion_r124574322
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java
---
@@ -130,6 +132,12 @@ public static BrooklynComponentTemplateResolver
newInstance(BrooklynClassLoading
private static BrooklynComponentTemplateResolver
newInstance(BrooklynClassLoadingContext context, ConfigBag attrs,
AbstractResource optionalTemplate) {
String type = getDeclaredType(null, optionalTemplate, attrs);
+ if (type == null) {
--- End diff --
Can type be the empty string? Might want to consider doing
StringUtils.isEmpty
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
