Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/746#discussion_r127427771
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java
---
@@ -64,14 +62,26 @@ public CatalogBundleLoader(Predicate<Bundle>
applicationsPermitted, ManagementCo
this.managementContext = managementContext;
}
+ public void scanForCatalog(Bundle bundle, boolean force, boolean
validate) {
+ scanForCatalogInternal(bundle, force, validate, false);
+ }
+
/**
* Scan the given bundle for a catalog.bom and adds it to the catalog.
*
* @param bundle The bundle to add
* @return A list of items added to the catalog
* @throws RuntimeException if the catalog items failed to be added to
the catalog
*/
- public Iterable<? extends CatalogItem<?, ?>> scanForCatalog(Bundle
bundle) {
+ public Iterable<? extends CatalogItem<?, ?>>
scanForCatalogLegacy(Bundle bundle) {
--- End diff --
Now that you've removed `CatalogBomScanner` this method isn't used any
more, I think we can get rid of it and the one below. See also comments on
`OsgiManager.java`. I think we can also get rid of `applicationsPermitted` in
this class, in the one place that its constructor is called the predicate is
hardcoded to `true`. The interesting case is on line 98 below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
