Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/767
@neykov good point about `BrooklynJavascriptGuiLauncher` (and the
`BrooklynRestApiLauncher` that it delegates to). I'd forgotten about those.
The existing `BrooklynJavascriptGuiLauncher` is only used in a couple of
simple tests (in `BrooklynJavascriptGuiLauncherTest`). It is not configurable
to inject a management context, which is what I want to do (obviously we could
add that if we chose).
The `BrooklynRestApiLauncher` can be configured with a management context
but does not include the UI. There is a surprisingly large amount of code in
that class! I presume it's duplicating what is in `BrooklynLauncher`. I
therefore much prefer my approach of just extending `BrooklynLauncher`,
overriding `start()`.
At some point we could try re-writing `BrooklynRestApiLauncher` to extend
`BrooklynLauncher`, but just now I don't want to risk accidentally breaking all
the rest-api tests that use `BrooklynRestApiLauncher`. I suggest we come back
to that in another PR in the future.
@neykov are you ok with merging this as-is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
