Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/782#discussion_r130148929
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java
---
@@ -101,6 +105,14 @@
@Context
private UriInfo uriInfo;
+ /**
+ * Only lower-case letters and digits; min 10 chars; max 1024 chars.
+ *
+ * We are this extreme because some existing entity implementations
rely on the entity-id format
+ * for use in hostnames, etc.
+ */
+ private final Pattern appIdPattern =
Pattern.compile("[a-z0-9]{10,1022}");
--- End diff --
For max length, I don't know what a good number is! If we're worried about
it being used in cloud resource names, we might need to restrict it to < 64
chars. but that seems far too restrictive for ids (coming back to Mark's point
about the use of proper UUID generators).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
