Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/798#discussion_r133440239
--- Diff:
core/src/main/java/org/apache/brooklyn/core/typereg/BasicBrooklynTypeRegistry.java
---
@@ -179,8 +180,21 @@ public RegisteredType get(String
symbolicNameWithOptionalVersion) {
public <SpecT extends AbstractBrooklynObjectSpec<?,?>> SpecT
createSpec(RegisteredType type, @Nullable RegisteredTypeLoadingContext
constraint, Class<SpecT> specSuperType) {
Preconditions.checkNotNull(type, "type");
if (type.getKind()!=RegisteredTypeKind.SPEC) {
--- End diff --
Very minor personal preference: the nesting of ifs seems strange to me. I'd
have written:
```
if (type.getKind() == RegisteredTypeKind.SPEC) {
return createSpec(...);
} else if (type.getKind() == RegisteredTypeKind.UNRESOLVED) {
...
} else {
throw new UnsupportedTypePlanException(...);
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
