Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/750#discussion_r138606936
--- Diff:
policy/src/main/java/org/apache/brooklyn/policy/location/CreateLocationPolicy.java
---
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.policy.location;
+
+import java.util.Map;
+import java.util.NoSuchElementException;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import org.apache.brooklyn.api.catalog.CatalogItem;
+import org.apache.brooklyn.api.entity.EntityLocal;
+import org.apache.brooklyn.api.policy.PolicySpec;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.api.sensor.SensorEvent;
+import org.apache.brooklyn.api.sensor.SensorEventListener;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.entity.trait.Startable;
+import org.apache.brooklyn.core.policy.AbstractPolicy;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.annotations.Beta;
+import com.google.common.base.Joiner;
+import com.google.common.base.Predicates;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.Iterables;
+import com.google.common.reflect.TypeToken;
+
+/**
+ * Policy that is attached to an entity to create a location configured
+ * using its sensor data. The created location is added to the catalog
+ * and will be removed when the entity is no longer running, based on
+ * the entity {@link Startable#SERVICE_UP} sensor status.
+ * <p>
+ * The policy definition includes configuration for the id, name and
+ * type of the location, as well as the {@link #LOCATION_CONFIG} map
+ * of config keys and the sensors used to define them.
+ * <p>
+ * The YAML below shows a policy that creates a {@code jclouds:aws-ec2}
+ * location with the region defined by a sensor on the entity it is
+ * attached to:
+ * <pre>{@code
+ * name: My App
+ * brooklyn.policies:
+ * - type: org.apache.brooklyn.policy.location.CreateLocationPolicy
+ * id: create-my-cloud-location
+ * brooklyn.config:
+ * location.catalogId: my-cloud
+ * location.displayName: "My Cloud"
+ * location.type: jclouds:aws-ec2
+ * location.config:
+ * region: $brooklyn:sensor("aws.region")
+ * }</pre>
+ *
+ */
+@Beta
+public class CreateLocationPolicy extends AbstractPolicy {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(CreateLocationPolicy.class);
+
+ public static Builder builder() {
+ return new Builder();
+ }
+
+ public static class Builder {
+ private String id;
+ private String name;
+ private AttributeSensor<Boolean> status;
+ private Map<String,AttributeSensor<?>> configuration;
+ private String catalogId;
+ private String displayName;
+ private String type;
+ private Set<String> tags;
+
+ public Builder id(String val) {
+ this.id = val; return this;
+ }
+ public Builder name(String val) {
+ this.name = val; return this;
+ }
+ public Builder status(AttributeSensor<Boolean> val) {
+ this.status = val; return this;
+ }
+ public Builder configuration(Map<String,AttributeSensor<?>> val) {
+ this.configuration = val; return this;
+ }
+ public Builder catalogId(String val) {
+ this.catalogId = val; return this;
+ }
+ public Builder displayName(String val) {
+ this.displayName = val; return this;
+ }
+ public Builder type(String val) {
+ this.type = val; return this;
+ }
+ public Builder tags(Set<String> val) {
+ this.tags = val; return this;
+ }
+ public CreateLocationPolicy build() {
+ return new CreateLocationPolicy(toFlags());
--- End diff --
Delete this `build` method - folk should always use the `PolicySpec`. I'd
probably go further and delete the builder entirely, relying on using the
standard `PolicySpec` as the way to build it.
---
