GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/821
REST API for accessing adjuncts (including highlights)
NB: builds on #810 and #818, review and merge those first
This is then just one commit (currently) which:
* adds an `AdjunctApi` combining all the functionality of `PolicyApi` and
`PolicyConfigApi` generalized across adjunct types
* same for `AdjunctConfigSummary`
* deprecates the replaced policy-specific endpoints and related classes,
and also the `CatalogApi` `/catalog` endpoint (since we are deprecating; also
there is some overlap at `CatalogPolicyItem` and `PolicyConfigSummary` etc)
This is mostly a drop-in replacement for the
`/applications/XXX/entities/XXX/policies/*` endpoints, now using
`/applications/XXX/entities/XXX/adjuncts/*` and returning other items. Note
also that:
* `GET /v1/applications/XXX/entities/XXX/adjuncts?adjunctType=policy`
filters by policy (same for other types)
* `adjunctType` is included in the returned object
* the detail object if you `GET
/v1/applications/XXX/entities/XXX/adjuncts/XXX` includes more info (config keys
aka parameters, and values)
* the `links` on the detail object include links to `start` and `stop` if
and only if the adjunct supports that (ie enrichers don't for instance)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-server
adjunct-rest-api-and-highlights
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/821.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #821
----
commit 9b337035992f77c7e156bba4d3b3ce35438ca180
Author: Alex Heneveld <[email protected]>
Date: 2017-09-07T15:43:45Z
REST API for bundles, types, and subtypes
also tweaks to other classes to make them more usable, eg VersionedName
comparables and bundle removal giving an OsgiBundleInstallationResult
test in BundleAndTypeAndSubtypeResourcesTest based on CatalogResourceTest,
basically giving parity in terms of functionality and test coverage
commit 1a8df4275d61ddd69e6bc05b057c081dd4dcad34
Author: Alex Heneveld <[email protected]>
Date: 2017-09-13T08:07:44Z
use highlights in `ServiceRestarter`
commit 5ae9c41c1dc8d2884598a2375581d2c4dc14ce14
Author: Alex Heneveld <[email protected]>
Date: 2017-09-13T08:24:09Z
expand API for policy java authors, and address PR comments incl javadoc
see ServiceRestarter for example of how the API can be used by authors now
commit 717084697c206e84a19922ec1dc30945b82523db
Author: Alex Heneveld <[email protected]>
Date: 2017-09-13T10:39:30Z
Set highlights on many more things
* selected policies (autoscaler, restarter, replacer, membership trackers)
- triggers, actions, and confirmations/violations
* triggers for most enrichers (with new conveniences added for sensor
triggers)
* period trigger for all feeds (from `Poller` using new
`highlightTriggerPeriod` in `AbstractFeed`)
* publish sensor actions for all enrichers (new
`highlightActionPublishSensor` convenience for `AbstractEntityAdjuct`, called
in `AbstractEnricher`, and in feed handlers via new `AbstractFeed.onSensor..`
methods)
commit 1cd6bf455d4cd0004a98881cc2d9a045bf2ffd1e
Author: Alex Heneveld <[email protected]>
Date: 2017-09-13T11:53:30Z
Merge branch 'master' into bundle-rest-api
BrooklynCatalog api tidy minor conflict
commit 80a4c255d595d4df9a2af7199b9a03e9f2a5641d
Author: Alex Heneveld <[email protected]>
Date: 2017-09-13T15:52:14Z
Merge branch 'bundle-rest-api' into adjunct-rest-api-and-highlights-2
commit 2860af56a7e77de8742fb3b6a0c22903f33e3a6b
Author: Alex Heneveld <[email protected]>
Date: 2017-09-13T15:52:27Z
Merge branch 'highlights-adjuncts' into adjunct-rest-api-and-highlights-2
commit 07247e8f15447e362222b8e2f705f025b59be3a2
Author: Alex Heneveld <[email protected]>
Date: 2017-09-13T15:22:56Z
add adjunct REST API, deprecating policy endpoint
----
---
