Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/129#discussion_r139284272
  
    --- Diff: software/cm/chef/src/main/resources/catalog.bom ---
    @@ -0,0 +1,26 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +brooklyn.catalog:
    +    version: "0.12.0-SNAPSHOT" # BROOKLYN_VERSION
    +    itemType: entity
    +    items:
    +    - id: org.apache.brooklyn.entity.chef.ChefEntity
    +      item:
    +        type: org.apache.brooklyn.entity.chef.ChefEntity
    +        name: Chef Entity
    +        description: Software managed by Chef
    --- End diff --
    
    Shouldn't you add directly the `iconUrl` field to match the changes made in 
#128 ?


---

Reply via email to