Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/833#discussion_r139935768
--- Diff:
policy/src/main/java/org/apache/brooklyn/policy/action/AbstractScheduledEffectorPolicy.java
---
@@ -210,16 +227,35 @@ protected Duration getWaitUntil(String time) {
}
}
+ protected Date parseTime(String time) throws ParseException {
+ boolean formatted = time.contains(":"); // FIXME deprecated
TimeDuration coercion
+ if (formatted) {
+ synchronized (FORMATTER) {
+ // DateFormat is not thread-safe; docs say to use
one-per-thread, or to synchronize externally
+ return FORMATTER.parse(time);
--- End diff --
Good catch
---
