GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/847
Catalog init refactor
Builds on code tidy/deletions in
https://github.com/apache/brooklyn-server/pull/846. Please review/merge that
first, and then I'll rebase this. Only the final commit in this PR needs
reviewed separately.
Move catalog init code to `CatalogInitialization`
Move code from `RebindIteration` so it delegates everything to the
`CatalogInitialization`.
Just refactors (no change in behaviour).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server catalog-init-refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/847.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #847
----
commit c8cc5520995f42eb87477cc4c66288c60c2db3a7
Author: Aled Sage <[email protected]>
Date: 2017-09-26T11:32:20Z
Delete deprecated CatalogLoadMode
commit adfe684630a33f6934399c44db59b2a6874af893
Author: Aled Sage <[email protected]>
Date: 2017-09-26T11:36:32Z
Delete deprecated RebindManager.rebind() methods
commit 88ac951800efa755896fad53e032fb636781e760
Author: Aled Sage <[email protected]>
Date: 2017-09-26T11:40:26Z
Delete `--catalogReset` from classic mode
commit b2bee5b55998add78bb344f552b2fd91303c5c55
Author: Aled Sage <[email protected]>
Date: 2017-09-26T11:51:42Z
Delete `--catalogAdd` from classic mode
Also delete `--catalogForce` (which only applied to the catalogAdd items)
commit 31b0a833be86e6fa7879e2042387aa3dae6e3189
Author: Aled Sage <[email protected]>
Date: 2017-09-26T11:57:16Z
Delete deprecated RebindManager.forcePersistNow()
commit 596a8355733edd8080b3f3ceea8cbda2569395cd
Author: Aled Sage <[email protected]>
Date: 2017-09-26T12:14:11Z
Delete deprecated ImmediateDeltaChangeListener
commit 0a5c19c3dabf64fcd9c50a7427d392bff9898cf2
Author: Aled Sage <[email protected]>
Date: 2017-09-26T12:16:04Z
Delete deprecated RebindManagerImpl.setPeriodicPersistPeriod(long)
commit e596e29f8c82ca665c1223abce34525d004652a0
Author: Aled Sage <[email protected]>
Date: 2017-09-26T12:20:41Z
BasicEntityMemento: fix getting config keys
commit 19bf0075c843c83b6f9164601efc405daa0da302
Author: Aled Sage <[email protected]>
Date: 2017-09-26T12:21:01Z
MementosGenerator: fix use of deprecated code
commit 2a4900e99830af36c70e41d47d97ebf47c0a5f02
Author: Aled Sage <[email protected]>
Date: 2017-09-27T14:02:33Z
Move catalog init code to CatalogInitialization
Move code from `RebindIteration` so it delegates everything to the
CatalogInitialization.
Just refactors (no change in behaviour).
----
---
