Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/829#discussion_r141826617
  
    --- Diff: 
policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceRestarter.java ---
    @@ -133,6 +135,10 @@ protected synchronized void 
onDetectedFailure(SensorEvent<Object> event) {
                 LOG.warn("ServiceRestarter suspended, so not acting on failure 
detected at "+entity+" ("+event.getValue()+")");
                 return;
             }
    +        if (isEntityStopping()) {
    +            highlightViolation("Failure detected but entity stopping");
    --- End diff --
    
    Should we highlight the violation here? I guess the question is more: is it 
really a violation when we are in a stopping state?


---

Reply via email to