Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/126#discussion_r142703444
  
    --- Diff: 
software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/mongodb/sharding/MongoDBRouterClusterImpl.java
 ---
    @@ -56,12 +60,17 @@ public void start(Collection<? extends Location> 
locations) {
         
         public static class MemberTrackingPolicy extends 
AbstractMembershipTrackingPolicy {
             @Override protected void onEntityEvent(EventType type, Entity 
member) {
    +            defaultHighlightAction(type, entity);
                 ((MongoDBRouterClusterImpl)super.entity).setAnyRouter();
             }
             @Override protected void onEntityRemoved(Entity member) {
    +            // TODO shouldn't be invoked - remove
    +            log.warn("Removal handler should be hidden by event handler", 
new Throwable("Trace for unexpected mongo node handler"));
    --- End diff --
    
    more a note to developer (it caught me out) - due to the `onEntityEvent` 
handler being overridden this method is not used


---

Reply via email to