Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/835#discussion_r143084004
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/config/ConfigConstraints.java ---
    @@ -112,12 +115,21 @@ public ConfigConstraints(T brooklynObject) {
         abstract Iterable<ConfigKey<?>> getBrooklynObjectTypeConfigKeys();
     
         public Iterable<ConfigKey<?>> getViolations() {
    -        // TODO in new task
    -        return validateAll();
    +        ExecutionContext exec = 
    +            getBrooklynObject() instanceof EntityInternal ? 
((EntityInternal)getBrooklynObject()).getExecutionContext() :
    +            // getBrooklynObject() instanceof AbstractEntityAdjunct ? 
((AbstractEntityAdjunct)getBrooklynObject()).getExecutionContext() :
    --- End diff --
    
    yep, in this case it should have been uncommented as part of this PR


---

Reply via email to