Hi Alex. So you can still debug the code if you attach a debugger before running the karaf shell. However, this does not support hot-deployment like you could do from within an IDE. So I think you're right, we need to keep the Main class. But since we want to use it for debug purpose, I would move it to the `test` folder rather than deprecating it.
Best. On Tue, 10 Oct 2017 at 12:24 Alex Heneveld <[email protected]> wrote: > > +1 for removing classic mode in the dist and in the docs > > NOT for removing the Main class itself however, I don't think -- this is > my standard way to run Brooklyn from the IDE and I don't have a karaf > replacement that supports debug mode in the same way, and also note most > of our unit tests still run classic mode rather than karaf. > > Best > Alex > > > On 09/10/2017 14:04, Mark McKenna wrote: > > +1 > > > > *Mark McKenna* > > > > *Twitter ::* @m4rkmckenna <https://twitter.com/m4rkmckenna> > > > > *Github :: *m4rkmckenna <https://github.com/m4rkmckenna> > > > > *PGP :: A7A9 24DE 638C 681A 8DEA FAD4 2B5D C759 B1EB 76A7 > > <https://pgp.mit.edu/pks/lookup?op=get&search=0x2B5DC759B1EB76A7>* > > > > On 9 October 2017 at 13:09, Graeme Miller <[email protected]> wrote: > > > >> +1 > >> > >> On 9 October 2017 at 12:56, Thomas Bouron < > [email protected] > >> wrote: > >> > >>> +1 > >>> > >>> On Mon, 9 Oct 2017 at 12:39 Geoff Macartney < > >> [email protected]> > >>> wrote: > >>> > >>>> +1 > >>>> > >>>> On Mon, 9 Oct 2017 at 12:38 Duncan Godwin <dgodwin@redwintechnologies. > >>> com> > >>>> wrote: > >>>> > >>>>> +1 > >>>>> > >>>>> On 9 October 2017 at 12:24, Richard Downer <[email protected]> > >> wrote: > >>>>>> I offer my opinion through the medium of GIFs: > >>>>>> > >>>>>> https://media.giphy.com/media/vohOR29F78sGk/giphy.gif > >>>>>> > >>>>>> Richard. > >>>>>> > >>>>>> > >>>>>> On 9 October 2017 at 12:13, Aled Sage <[email protected]> wrote: > >>>>>> > >>>>>>> Hi all, > >>>>>>> > >>>>>>> I propose that we *delete* Brooklyn classic-mode from master now, > >>> in > >>>>>>> preparation for the 1.0.0 release. > >>>>>>> > >>>>>>> --- > >>>>>>> > >>>>>>> In 0.12.0, we switched the main distro to be the karaf-mode. We > >>> also > >>>>>> built > >>>>>>> the classic-mode distro - the intent being for users to have a > >>> usable > >>>>>>> classic mode, rather than being forced immediately to switch to > >>> karaf > >>>>>>> without advanced warning. > >>>>>>> > >>>>>>> However, we unfortunately did not deprecate classic-mode as > >> clearly > >>>> as > >>>>> we > >>>>>>> should have (e.g. didn't explicitly say that it will be deleted > >> in > >>> an > >>>>>>> upcoming release, and didn't deprecate the `Main` class). > >>>>>>> > >>>>>>> I think it's still ok to delete it for several reasons: > >>>>>>> > >>>>>>> 1. This is a "mode" of running Brooklyn, rather than underlying > >>>>>>> Brooklyn functionality. > >>>>>>> 2. The `Main` class [1] etc should not be considered part of our > >>>>>>> *public* API (even though we didn't explicitly tell people > >> that > >>> it > >>>>>>> was internal). > >>>>>>> 3. As part of 0.12.0 release, we added to the docs instructions > >> for > >>>>>>> upgrading to Karaf [2]. > >>>>>>> 4. Supporting classic to the same standard as Karaf will become > >>>>>>> increasingly painful as we do more and more with Bundles! > >>>>>>> 5. It's a major release, so if we are going to delete it then > >> 1.0.0 > >>>> is > >>>>>>> the perfect time! > >>>>>>> > >>>>>>> Aled > >>>>>>> > >>>>>>> [1] https://github.com/apache/brooklyn-server/blob/master/server > >>>>>>> -cli/src/main/java/org/apache/brooklyn/cli/Main.java > >>>>>>> > >>>>>>> [2] http://brooklyn.apache.org/v/0.12.0/ops/upgrade.html#upgrade > >>>>>>> -from-apache-brooklyn-0110-and-below > >>>>>>> > >>>>>>> > >>>>>>> > >>> -- > >>> > >>> Thomas Bouron • Senior Software Engineer @ Cloudsoft Corporation • > >>> https://cloudsoft.io/ > >>> Github: https://github.com/tbouron > >>> Twitter: https://twitter.com/eltibouron > >>> > > -- Thomas Bouron • Senior Software Engineer @ Cloudsoft Corporation • https://cloudsoft.io/ Github: https://github.com/tbouron Twitter: https://twitter.com/eltibouron
