GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-server/pull/869
Reverted code for selecting subnet hostname for non aws clouds
A change was made to how Brooklyn retrieves the subnet hostname in
https://github.com/apache/brooklyn-server/pull/849.
The intention of that PR was to remove AWS specific functionality, but
instead it affected all clouds as it moved all clouds to using
```node.getHostname()```. This functionality cant be relied on for a number of
clouds. Openstack, for instance, were getting subnet hostnames like
'qa-tomcat-ser-lc5dhz8sm3-b80' which do not work. Other affected clouds include
Azure and Softlayer.
This PR changes the code back to before 849, whilst still removing the AWS
specific functionality. However, when testing this code, I discovered that for
most clouds we do not actually get a subnet hostname. Instead we use the subnet
IP. It's only really AWS that would get a subnet hostname as it uses the AWS
specific code. If people prefer, we can simply revert
https://github.com/apache/brooklyn-server/pull/849 instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Graeme-Miller/brooklyn-server
fix_subnet_hostname
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #869
----
commit 9872e1082e043fd5157c39a2ea6a2dc1e8e37d0e
Author: graeme.miller <[email protected]>
Date: 2017-10-24T14:57:54Z
Reverted code for selecting subnet hostname for non aws clouds
----
---
