Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/868#discussion_r147079793
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
 ---
    @@ -1492,7 +1503,7 @@ protected OsgiBundleInstallationResult 
addItemsOsgi(String yaml, boolean forceUp
     
             OsgiBundleInstallationResult result = null;
             try {
    -            result = osgiManager.get().install(null, new 
FileInputStream(bf), true, true, forceUpdate).get();
    +            result = osgiManager.get().install(new 
BasicManagedBundle(vn.getSymbolicName(), vn.getVersionString(), null), new 
FileInputStream(bf), true, true, forceUpdate).get();
    --- End diff --
    
    Should we use `vn.getOsgiVersionString()`, given that it's the OSGi 
bundle's metadata?


---

Reply via email to