Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/899#discussion_r152321945
  
    --- Diff: 
launcher/src/test/java/org/apache/brooklyn/launcher/AbstractBrooklynLauncherRebindTest.java
 ---
    @@ -184,7 +190,87 @@ protected File newTmpBundle(Map<String, byte[]> files, 
VersionedName bundleName,
             }
             return bf;
         }
    +
    +    BundleFile.Builder bundleBuilder() {
    +        return new BundleFile.Builder(this);
    +    }
         
    +    protected static class BundleFile {
    --- End diff --
    
    It's currently tied to `AbstractBrooklynLauncherRebindTest`: it uses 
`test.newTmpBundle(...)`, which stores the created bundle file in the field 
`tmpFiles` so that they are deleted in `tearDown`.
    
    Might well be worth extracting this into a utility that is re-used across 
multiple tests instead. I'll stick with it as-is for now, until we want to 
re-use it somewhere else, and we break that `tmpFiles` link.


---

Reply via email to