Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/916#discussion_r156406908
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java ---
@@ -799,6 +795,12 @@ protected Entity replaceMember(Entity member,
@Nullable Location memberLoc, Map<
/** <strong>Note</strong> for sub-classes; this method can be called
while synchronized on {@link #mutex}. */
protected Collection<Entity> grow(int delta) {
Preconditions.checkArgument(delta > 0, "Must call grow with
positive delta.");
+ Integer maxSize = config().get(MAX_SIZE);
+ final int desiredSize = getCurrentSize() + delta;
+ if (maxSize != null && desiredSize > maxSize) {
--- End diff --
I think we need a corresponding check for `MIN_SIZE` in `shrink(int delta)`
---
