Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/908#discussion_r157783475
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/enricher/stock/aggregator/DashboardAggregator.java
 ---
    @@ -0,0 +1,81 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.enricher.stock.aggregator;
    +
    +import java.util.Map;
    +import java.util.concurrent.Callable;
    +
    +import org.apache.brooklyn.api.entity.EntityLocal;
    +import org.apache.brooklyn.api.mgmt.Task;
    +import org.apache.brooklyn.core.enricher.AbstractEnricher;
    +import org.apache.brooklyn.core.mgmt.BrooklynTaskTags;
    +import org.apache.brooklyn.core.sensor.BasicAttributeSensorAndConfigKey;
    +import org.apache.brooklyn.util.core.task.ScheduledTask;
    +import org.apache.brooklyn.util.core.task.Tasks;
    +import org.apache.brooklyn.util.time.Duration;
    +
    +/**
    + * The DashboardAggregator is an enricher that combines config/sensor 
values from the children of the entity it is attached to.
    + * The combined values are set as sensors on the entity that it is 
attached to. Preference is given to the child entities sensors values,
    + * but if none are set, config values are used instead.
    + *
    + * The reason that this exists is to provide high level summary 
information, that could be useful to display on a dashboard.
    + * Whilst brooklyn itself has no such dashboard, we can imagine this 
entity being used in that fashion.
    + *
    + * Please note, that the DashboardAggregator will aggregate all children 
of the entity it is attached to, even intermediate level children.
    --- End diff --
    
    I'd say "all descendants" rather than "all children".


---

Reply via email to